Fix/grid list item accessibility issue in ios #3887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MIchaelZablianov
changed the title
adids1221
reviewed
Jan 13, 2026
| alignToStart={alignToStart} | ||
| overlayText={overlayText} | ||
| horizontalAlignment={horizontalAlignment} | ||
| containerProps={{accessible: false}} |
Contributor
There was a problem hiding this comment.
You can remove this two lines (56, 62) from the example screen.
adids1221
previously approved these changes
Jan 13, 2026
Contributor
adids1221
left a comment
adids1221
left a comment
There was a problem hiding this comment.
Approved, nice work 👍
Make sure to remove the unnecessary lines from the example screen before merging.
Contributor
✅ PR Description Validation PassedAll required sections are properly filled out:
Your PR is good for review! 🚀 This validation ensures all sections from the PR template are properly filled. |
adids1221
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix grid list item accessibility issue in ios:
issue: accessible containerProps.accessible doesn't override correctly the grid list container view's accessible prop.
fix: changed order in internal implementation to fix override priority
Changelog
fix grid list item accessibility issue in ios
Additional info
Ticket 4894