feat: add iconBackground support to backButton on iOS and Android #8160
Conversation
|
@markdevocht, should I merge master already? |
There was a problem hiding this comment.
Hey thanks @adids1221!
Could you add a visual of some sort describing what you need?
Also, please be sure to add at least one visual (e2e) test to cover this use case 🙏🏻
@markdevocht @gosha212 let's discuss whether this is the right approach (=API) once we understand the use case better
|
@markdevocht thank you for the help! The issue solved by adding the if statment in |
markdevocht
left a comment
markdevocht
left a comment
There was a problem hiding this comment.
Also I saw @d4vidi left a comment in his review about finding another way of doing it.
ios/RNNIconDrawer.mm
Outdated
| UIImage *newImage = UIGraphicsGetImageFromCurrentImageContext(); | ||
| UIGraphicsEndImageContext(); | ||
|
|
||
| if (color && color != UIColor.clearColor) { |
There was a problem hiding this comment.
you can remove the color != UIColor.clearColor
| os: '15.5', | ||
| type: 'iPhone 16', | ||
| os: '18.2', | ||
| }, |
There was a problem hiding this comment.
This is your change? if so, make sure to update all the snapshots from the snapshot tests. BUT I don't think you should update this.
Description
Adds
iconBackgroundproperty support tobackButtonoptions, matching the functionality available forrightButtonsandleftButtons.This enables circular and rounded background shapes behind the back button icon, consistent with regular button styling.
Changes:
iconBackground?: IconBackgroundOptions;toOptionsTopBarBackButtonTypeScript interfaceiconBackgroundinBackButtonclass, apply viaButtonPresenter.applyNavigationIcon()iconBackgroundproperty toRNNBackButtonOptions, parse and merge, render usingRNNIconDrawerTechnical Details:
IconBackgroundDrawableinfrastructure viaapplyIconBackgroundDrawable()methodRNNIconDrawerdirectly (simpler approach, no need for full icon creator system), added one more case.color,disabledColor,cornerRadius,width,heightpropertiesChangelog
BackButton - Added
iconBackgroundproperty support. Back button icons can now display circular or rounded backgrounds matching the styling of regular navigation buttons.Additional info
MADS-4884