Animation end fix#227
Open
ameerf-wix wants to merge 10 commits into
Open
Conversation
ydaniv
requested changes
May 27, 2026
| )?.animations; | ||
|
|
||
| if (sourceGroup && sourceGroup.length) { | ||
| if (sourceGroup.some((a: Animation) => a.playState === 'running')) { |
Collaborator
There was a problem hiding this comment.
We already have AnimationGroup.playState which checks animations[0].playState. If this is too simple we can change the implementation, but better move the logic into AnimationGroup
Contributor
Author
There was a problem hiding this comment.
changed AnimationGroup.playState to return running if any of the animations within has this playState and otherwise fallback to old impl (taking animations[0].playState) - do you think more logic is needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Checklist
Screenshots / Demos
Additional Notes