Add Hostinger deployment guide#13835
Conversation
Adds a deploy guide for Hostinger covering both static and Node.js (server-rendered) deployments via hPanel, plus the corresponding hostinger logo and a `logos.ts` entry to satisfy the deploy-page schema. Resubmission of withastro#13649 with build/schema issues fixed.
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
ArnasDon
left a comment
There was a problem hiding this comment.
No failing tests from automatic checks. Based on the previously closed PR, fixed them and opened a new PR.
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Thank you! Overall, this looks good to me. I made a few suggestions, but they were mostly nitpicks. My biggest concern is the logo: does Hostinger as a smaller version that can be used (see my comment on the logo file)?
Replaces the wide wordmark SVG with the official Hostinger "h" icon mark, which matches the icon-style format used by neighboring deploy guides (Heroku, Microsoft Azure, etc.) and renders at a more readable size in the deploy index card grid.
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Thank you for the updates. The logo seems better integrated now. 😄 LGTM!
|
Great @ArmandPhilippot, thanks for reviewing the changes. Is another approval still required with writes access or you can approve this PR to be merged? |
|
A second approval is not required, but we generally do so for new content or significant changes. So yes, I'm waiting for someone else's review before merging this PR. Yan will probably do it this week, when he has the time! |
|
Gotcha! Thanks for the information. |
Description (required)
Adds a deploy guide for Hostinger covering both static site uploads (via hPanel File Manager / FTP) and Node.js (server-rendered) deployments via hPanel.
This is a resubmission of #13649, which was closed because the build was failing. The previous attempt had:
logo: hostingervalue with no matching key insrc/data/logos.ts, which is validated via `z.enum(logoKeys).parse(val)` and fails the build.This PR fixes all of the above:
Related issues & labels (optional)