test: remove "dataShareConsent" modal [WPB-22420]#21237
Merged
Conversation
JacquelineLehner
requested review from
arjita-mitra,
e-maad,
otto-the-bot,
screendriver,
thisisamir98 and
zskhan
as code owners
markbrockhoff
previously approved these changes
May 5, 2026
zskhan
previously approved these changes
May 5, 2026
e-maad
previously approved these changes
May 6, 2026
JacquelineLehner
force-pushed
the
jl/refactor-dataShareConsent-modal
branch
2 times, most recently
from
6343ce0 to
73b6f5f
Compare
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/CriticalFlow/joinTeam-TC-8635.spec.ts (❌ 0 failed,
|
JacquelineLehner
dismissed stale reviews from zskhan, markbrockhoff, and e-maad
via
397ca22
JacquelineLehner
force-pushed
the
jl/refactor-dataShareConsent-modal
branch
from
73b6f5f to
397ca22
Compare
zskhan
previously approved these changes
May 8, 2026
… with functions of confirm modal Refs: WPB-22420
Refs: WPB-22420 # Conflicts: # apps/webapp/test/e2e_tests/pageManager/index.ts
Refs: WPB-22420
JacquelineLehner
force-pushed
the
jl/refactor-dataShareConsent-modal
branch
from
397ca22 to
6313a96
Compare
Refs: WPB-22420
|
zskhan
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the dataShareConsent modal.
Changes made:
dataShareConsent.modal.tsto reduce boilerplate and simplify the modal inheritance structure.