fix: change bg effects implementation [WPB-24370]#21220
Merged
Conversation
… and performance improvements
…handling and worker options
EnricoSchw
requested review from
arjita-mitra,
e-maad,
otto-the-bot,
screendriver,
thisisamir98 and
zskhan
as code owners
EnricoSchw
changed the title
…, `worker-timers`, and related packages
Contributor
Author
|
Please pay special attention to the new dependency. It has some advantages but comes with a few significant behavioral changes. |
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
|
…mprove nullable type handling in `BackgroundEffectsHandler`
…s, and remove all zero fractions in numbers.
…er model handling also add logs for more visibility
…checkbox feat: enable high quality blur option and update related handlers [WPB-25492]
screendriver
previously requested changes
May 11, 2026
Member
screendriver
left a comment
screendriver
left a comment
There was a problem hiding this comment.
This refactor changes core pipeline behavior significantly. I'd feel safer if we add targeted tests for restart serialization + background-switch ordering (stale bitmap prevention), since those are the highest-risk race paths.
…omprehensive tests
…, `worker-timers`, and related packages
… effects processing
…ing of image bitmaps
… cleanup and message handling
…ons` for runtime updates
…` context handling
Contributor
Author
|
@screendriver Could you please review and approve this for us? |
|
zskhan
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summery
With the current implementation, we've reached our limits. The implementation was so complex that we could only consider large parts of it as a black box. Unfortunately, it wasn't stable enough for that, so we decided to simplify it significantly.
Before:
After: