chore: add configuration for on-prem env [WPB-3615]#20524
Open
chore: add configuration for on-prem env [WPB-3615]#20524
Conversation
e-maad
requested review from
V-Gira,
arjita-mitra,
mathias-niboulies,
nkaramarko,
otto-the-bot,
screendriver,
thisisamir98 and
zskhan
as code owners
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #20524 +/- ##
==========================================
- Coverage 45.44% 45.44% -0.01%
==========================================
Files 1637 1637
Lines 40361 40361
Branches 8332 8332
==========================================
- Hits 18342 18341 -1
Misses 20086 20086
- Partials 1933 1934 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
|
e-maad
changed the title
e-maad
changed the title
Comment on lines
+22
to
+24
| const fs = require('fs'); | ||
| const path = require('path'); | ||
| const {spawn} = require('child_process'); |
Member
There was a problem hiding this comment.
Avoid CommonJS (it's legacy/deprecated) at all costs and use ECMAScript modules
| const {spawn} = require('child_process'); | ||
|
|
||
| // Parse command line arguments | ||
| const args = process.argv.slice(2); |
Member
| const environment = args[0] || 'dev'; | ||
|
|
||
| // Available environments | ||
| const availableEnvs = ['dev', 'anta', 'bella', 'chala', 'fulu', 'imai', 'foma']; |
Member
There was a problem hiding this comment.
Suggested change
| const availableEnvs = ['dev', 'anta', 'bella', 'chala', 'fulu', 'imai', 'foma']; | |
| const availableEnvs = ['dev', 'anta', 'bella', 'chala', 'fulu', 'imai', 'foma'] as const; |
|
|
||
| // Parse command line arguments | ||
| const args = process.argv.slice(2); | ||
| const environment = args[0] || 'dev'; |
Member
There was a problem hiding this comment.
Suggested change
| const environment = args[0] || 'dev'; | |
| const environment = args[0] ?? 'dev'; |
|
|
||
| for (const line of lines) { | ||
| // Skip empty lines and comments | ||
| if (!line.trim() || line.trim().startsWith('#')) { |
Member
There was a problem hiding this comment.
Suggested change
| if (!line.trim() || line.trim().startsWith('#')) { | |
| const trimmedLine = line.trim(); | |
| if (trimmedLine === '' || trimmedLine.startsWith('#')) { |
| if (!availableEnvs.includes(environment)) { | ||
| console.error(`\n❌ Invalid environment: ${environment}`); | ||
| showUsage(); | ||
| process.exit(1); |
Member
There was a problem hiding this comment.
Suggested change
| process.exit(1); | |
| process.exitCode = 1; |
| @@ -0,0 +1,207 @@ | |||
| #!/usr/bin/env node | |||
Member
There was a problem hiding this comment.
For the whole file we don't have any tests that verify the expected behavior
| @@ -0,0 +1,45 @@ | |||
| # Active environment: anta (merged with base .env) | |||
Member
There was a problem hiding this comment.
.env.backup is not a backup right? It's more like a fallback or default as far as I can see?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Added a script to dynamically switch environments without manually editing .env files.
Changes:
Created
start-with-env.js- accepts environment parameter (dev, anta, bella, chala, fulu, imai, foma)Updated yarn start to support yarn start [environment]
Moved all .env.* files to env/ folder for better organization
Security Checklist (required)
Accessibility (required)
Standards Acknowledgement (required)
Screenshots or demo (if the user interface changed)
Notes for reviewers