feat(commons): add anonhymizer to whitelist props in logs [WPB-24990]#8109
Open
e-maad wants to merge 2 commits into
Open
feat(commons): add anonhymizer to whitelist props in logs [WPB-24990]#8109e-maad wants to merge 2 commits into
e-maad wants to merge 2 commits into
Conversation
Member
|
|
|
zskhan
approved these changes
May 4, 2026
screendriver
reviewed
May 4, 2026
|
|
||
| import {anonymizer} from '@uphold/anonymizer'; | ||
|
|
||
| export const anonymize = anonymizer({ |
Member
There was a problem hiding this comment.
I'm concerned that this change wires the app directly to the concrete @uphold/anonymizer implementation (anonymize is exported as a library-specific instance), instead of introducing an explicit boundary.
I recommend we keep this behind a stable interface and inject the implementation where needed. This keeps call sites decoupled, improves testability (easy deterministic stubs) and makes future library swaps/config changes low-risk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Pull Request
Summary
Added anonymizer for whitelist properties visible in logs
Security Checklist (required)
Accessibility (required)
Standards Acknowledgement (required)
Screenshots or demo (if the user interface changed)
Notes for reviewers