internal: make domain-registration available for test env#5245
Merged
battermann merged 3 commits intoMay 29, 2026
Merged
Conversation
zebot
added
the
ok-to-test
blackheaven
approved these changes
May 28, 2026
fisx
approved these changes
May 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes internal domain-registration endpoints reachable through nginz for testing, protected by basic auth, and adds an internal changelog entry.
Changes:
- Adds nginz routing entries for
/i/domain-registration/...lock, unlock, preauthorize, unauthorize, and base GET/PUT/DELETE routes. - Marks the routes as unversioned, zauth-disabled, and basic-auth protected.
- Adds a changelog entry for the internal testing exposure.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
charts/nginz/values.yaml |
Adds nginz path configuration for internal domain-registration routes. |
changelog.d/5-internal/basic-auth-for-test-env |
Documents the internal API availability for testing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
battermann
force-pushed
the
battermann/enable-basic-auth-for-domain-registration-on-test-envs
branch
from
11e021b to
81f3556
Compare
battermann
deleted the
battermann/enable-basic-auth-for-domain-registration-on-test-envs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d