feat: multi-ingress SSO flow - WPB-23281#4698
Open
netbe wants to merge 3 commits into
Open
Conversation
|
Contributor
Test Results110 tests 110 ✅ 11s ⏱️ Results for commit 388c445. Summary: workflow run #25740299314 |
| switch emailOrSSOCode { | ||
| case let .email(email, domain): | ||
| return try await determineAuthMethod(email: email, domain: domain) | ||
| return try await checkDefaultSSO(email: email, domain: domain) |
Contributor
There was a problem hiding this comment.
thought: keeping determineAuthMethod at this level might help with having a high-level overview of the flow.
switch emailOrSSOCode {
case let .email(email, domain):
if let defaultSSOCode = try await defaultSSOCode(email: email, domain: domain) {
return .loginViaSSO(code: defaultSSOCode)
} else {
return try await determineAuthMethod(email: email, domain: domain)
}
}
// ...
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue
This PR adds multi-ingress SSO flow support for API v15.
Testing
See details in ticket's comment
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: