Skip to content

feat: multi-ingress SSO flow - WPB-23281#4698

Open
netbe wants to merge 3 commits into
developfrom
feat/multi-ingress
Open

feat: multi-ingress SSO flow - WPB-23281#4698
netbe wants to merge 3 commits into
developfrom
feat/multi-ingress

Conversation

@netbe
Copy link
Copy Markdown
Collaborator

@netbe netbe commented May 12, 2026

TaskWPB-23281 [iOS] Implement multi-ingress SSO flow

Issue

This PR adds multi-ingress SSO flow support for API v15.

  • Checks first if email has an associated sso code and redirect to login

Testing

See details in ticket's comment


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@netbe netbe marked this pull request as ready for review May 12, 2026 14:15
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

Test Results

110 tests   110 ✅  11s ⏱️
 22 suites    0 💤
  1 files      0 ❌

Results for commit 388c445.

Summary: workflow run #25740299314
Allure report (download zip): html-report-29926-feat_multi-ingress

switch emailOrSSOCode {
case let .email(email, domain):
return try await determineAuthMethod(email: email, domain: domain)
return try await checkDefaultSSO(email: email, domain: domain)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: keeping determineAuthMethod at this level might help with having a high-level overview of the flow.

switch emailOrSSOCode {
  case let .email(email, domain):
       if let defaultSSOCode = try await defaultSSOCode(email: email, domain: domain) {
           return .loginViaSSO(code: defaultSSOCode)
       } else {
           return try await determineAuthMethod(email: email, domain: domain)
       }
   }
   // ...
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants