chore: critical flow html reporting - WPB-22537 #4050
Conversation
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit d433161. ♻️ This comment has been updated with latest results. |
findms
changed the title
findms
changed the title
findms
changed the title
netbe
left a comment
netbe
left a comment
There was a problem hiding this comment.
Looks good, made a suggestion but maybe we discuss it as a separate point
| run_on: | ||
| required: false | ||
| type: string | ||
| default: "macos-latest" |
There was a problem hiding this comment.
question: why is this necessary?
| @@ -0,0 +1,92 @@ | |||
| name: Allure reporting 📊 | |||
There was a problem hiding this comment.
thought: I wonder if we should use an action instead of a workflow https://chris48s.github.io/blogmarks/posts/2021/composite-actions-reusable-workflows/
| publish_report: | ||
| name: Allure report | ||
| needs: [critical_flows] | ||
| if: always() | ||
| uses: ./.github/workflows/_reusable_allure_reporting.yaml | ||
| with: | ||
| branch_name: ${{ github.ref_name }} | ||
| secrets: inherit | ||
|
|
||
| report_summary: | ||
| name: Report Summary | ||
| needs: [critical_flows, publish_report] | ||
| runs-on: ubuntu-latest | ||
| if: always() | ||
| steps: | ||
| - name: Add Download Link to Summary | ||
| run: | | ||
| echo "## 📊 Critical Flows Test Report" >> $GITHUB_STEP_SUMMARY | ||
| echo "" >> $GITHUB_STEP_SUMMARY | ||
| echo "**Workflow:** Critical Flows" >> $GITHUB_STEP_SUMMARY | ||
| echo "**Run Number:** ${{ github.run_number }}" >> $GITHUB_STEP_SUMMARY |
There was a problem hiding this comment.
suggestion: move this to _reusable_run_tests.yml, we could remove the publish EnricoMi/publish-unit-test-result-action/macos@v2 and use this instead + update the Wire notifications to have the link to the report directly
|
|
||
| report_summary: | ||
| name: Report Summary | ||
| needs: [critical_flows, publish_report] |
There was a problem hiding this comment.
| needs: [critical_flows, publish_report] | |
| needs: [publish_report] |
Summary
Briefly describe about this PR changes.
A new yaml for allure reporting has been created and added as publish report and report summary to critical_flows.yaml.In pipeline Allure html report generation job is added sequentially after the test run. Whilerunning workflow manually after execution of run tests it generates allure report from *.xcresults with screenshot/video for failure cases.
This is how execution flow now looks:
Testing
Describe how to verify the changes locally. Attach screenshots of local execution if relevant.
ref PR: https://github.com/wireapp/wire-ios/actions/runs/20464908307To view the report, scroll down the run to look for allure report something like this:
this creates a single html file while can be opened to any browser and view the report.
this is how actual report looks like:
Additional Information
any more info, add here.