-
Notifications
You must be signed in to change notification settings - Fork 24
chore: remove dead non multibackend code paths - WPB-12140 #3975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
c764afa to
5552957
Compare
5552957 to
f9e1589
Compare
a0fcfc1 to
f9e1589
Compare
Test Results3 249 tests 3 222 ✅ 3m 55s ⏱️ Results for commit a326724. ♻️ This comment has been updated with latest results. |
wire-ios-sync-engine/Source/Synchronization/ZMOperationLoop+APIVersion.swift
Outdated
Show resolved
Hide resolved
…os into chore/remove-multibackend
This reverts commit 72957d2.
…re/remove-multibackend
…os into chore/remove-multibackend
…s/testForAUserWithALongName.1.png: convert to Git LFS
…s/testForAUserWithNoTeam.1.png: convert to Git LFS
3345269 to
864ae2c
Compare
50a662f to
6bec2dd
Compare
| return nil | ||
| } | ||
| return .init(value: apiVersion) | ||
| // TODO: [WPB-22512] remove BackendInfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leftover comment ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no next task, I needed to split this, it would be for another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why new snapshots ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these were disabled with multibackend, I re-enabled them and adjust the test to have just one account. There's a small misalignement though, I think it's ok
...on/Sources/WireAuthenticationUI/Views/DetermineAuthMethod/DetermineAuthMethodViewModel.swift
Outdated
Show resolved
Hide resolved
...on/Sources/WireAuthenticationUI/Views/DetermineAuthMethod/DetermineAuthMethodViewModel.swift
Outdated
Show resolved
Hide resolved
…eAuthMethod/DetermineAuthMethodViewModel.swift
Issue
This is one of the PRs removing multibackend dead code, this one focus on removing direct dead code:
Next:
Testing
Describe how to test.
Optional: attachments like images, videos, etc.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: