Skip to content

Conversation

@netbe
Copy link
Collaborator

@netbe netbe commented Dec 4, 2025

TaskWPB-12140 [iOS] Clean up legacy BackendEnvironment code

Issue

This is one of the PRs removing multibackend dead code, this one focus on removing direct dead code:

  • remove DeveloperFlag.multibackend
  • SharingSession convenience initializers

Next:

  • BackendEnvironment2 to be rename
  • remove WireTransport.BackendEnvironment
  • remove APIVersionResolver
  • remove dead AuthenticationCoordinator cases

Testing

Describe how to test.

Optional: attachments like images, videos, etc.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@netbe netbe changed the base branch from develop to chore/remove-oldblacklist December 7, 2025 15:10
@netbe netbe force-pushed the chore/remove-multibackend branch from c764afa to 5552957 Compare December 7, 2025 15:11
@netbe netbe changed the title chore: remove multibackend chore: remove dead non multibackend code paths - WPB-12140 Dec 8, 2025
@netbe netbe force-pushed the chore/remove-multibackend branch from 5552957 to f9e1589 Compare December 10, 2025 09:10
Base automatically changed from chore/remove-oldblacklist to develop December 11, 2025 12:28
@netbe netbe force-pushed the chore/remove-multibackend branch from a0fcfc1 to f9e1589 Compare December 16, 2025 14:26
@netbe netbe marked this pull request as ready for review December 17, 2025 15:31
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

Test Results

3 249 tests   3 222 ✅  3m 55s ⏱️
  474 suites     27 💤
    4 files        0 ❌

Results for commit a326724.

♻️ This comment has been updated with latest results.

@netbe netbe requested a review from johnxnguyen December 18, 2025 15:39
Base automatically changed from fix/slow-request-strategies-tests-cherry-pick to develop December 19, 2025 16:36
@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 5, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a326724 | Docs | Was this helpful? Give us feedback!

netbe added 3 commits January 5, 2026 16:19
@netbe netbe force-pushed the chore/remove-multibackend branch from 3345269 to 864ae2c Compare January 5, 2026 15:19
@netbe netbe requested a review from a team January 6, 2026 12:09
@netbe netbe force-pushed the chore/remove-multibackend branch from 50a662f to 6bec2dd Compare January 6, 2026 20:24
return nil
}
return .init(value: apiVersion)
// TODO: [WPB-22512] remove BackendInfo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover comment ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no next task, I needed to split this, it would be for another PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why new snapshots ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these were disabled with multibackend, I re-enabled them and adjust the test to have just one account. There's a small misalignement though, I think it's ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants