Skip to content

feat: Make files available offline (WPB-23968)#4811

Draft
ohassine wants to merge 39 commits into
developfrom
Make-files-available-offline
Draft

feat: Make files available offline (WPB-23968)#4811
ohassine wants to merge 39 commits into
developfrom
Make-files-available-offline

Conversation

@ohassine
Copy link
Copy Markdown
Member

@ohassine ohassine commented May 12, 2026

https://wearezeta.atlassian.net/browse/WPB-23968


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

Allow users to make files available offline, so they can browse them later when they don't have Internet

  • Added two new actions to "Make file offline" and "remove offline access"
  • Show download indication for offline files
  • Removing offline access of a file will delete the file from device, so user needs to download it again

Showing the list of offline files will be handled in next PR

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

ohassine added 30 commits April 23, 2026 18:56
# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
…le-offline

# Conflicts:
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFileActionsMenu.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFileLocalPathCache.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellFilesScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellListItem.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellScreenContent.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/CellViewModel.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/ConversationFilesWithSlideInTransitionScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/OpenFileDownloadController.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/model/CellNodeUi.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/model/NodeBottomSheetAction.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/model/OpenLoadState.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/ui/search/SearchScreen.kt
#	features/cells/src/main/java/com/wire/android/feature/cells/util/FileHelper.kt
#	features/cells/src/main/res/values/strings.xml
#	features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/CellFileActionsMenuTest.kt
#	features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/CellViewModelTest.kt
#	features/cells/src/test/kotlin/com/wire/android/feature/cells/ui/OpenFileDownloadControllerTest.kt
#	kalium
@pull-request-size
Copy link
Copy Markdown

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@github-actions
Copy link
Copy Markdown
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
a8197f63a4448c684ae60d3b4f895b3aac3b2910 e854de386df9e1d3b3d26e5a01132fdd86d3842d

Is this intentional?

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

@ohassine looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
a8197f63a4448c684ae60d3b4f895b3aac3b2910 e854de386df9e1d3b3d26e5a01132fdd86d3842d

Is this intentional?

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant