fix: Nomad profiles should not see app lock - WPB-25543#4808
fix: Nomad profiles should not see app lock - WPB-25543#4808marcoconti83 wants to merge 1 commit intodevelopfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4808 +/- ##
========================================
Coverage 51.13% 51.13%
========================================
Files 610 610
Lines 21089 21093 +4
Branches 3399 3399
========================================
+ Hits 10783 10786 +3
- Misses 9291 9295 +4
+ Partials 1015 1012 -3 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| if (coreLogic.getGlobalScope().doesValidNomadAccountExist()) { | ||
| send(AppLockConfig.Disabled(DEFAULT_APP_LOCK_TIMEOUT)) | ||
| return@collectLatest | ||
| } |
There was a problem hiding this comment.
would prefer to do this in kalium lvl where the use case for the team flag app lock will not emit enforced if the user have a nomad URL, doing this here is another DB call when the app starts that we do not need
my suggesiton will mean that the user will not add app lock in the first place
marcoconti83
changed the title
marcoconti83
force-pushed
the
marco/nomad-app-lock
branch
from
ef7b988 to
64fae00
Compare
|
2 participants
https://wearezeta.atlassian.net/browse/WPB-25543
What's new in this PR?
When an account is configured as a nomad profile, that account should not see any app lock prompt, even if the team administrator enforces app lock for the team.
Testing
I've manually tested this on Fulu on a team with app lock enabled