ci: run PR benchmark jobs on cloud runners

[typfel]

What's new in this PR

run PR benchmark jobs on cloud runners

---

PR Submission Checklist for internal contributors

• The PR Title
  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[coriolinus]

I'm approving because farming out the PR's benchmark jobs to GH cloud machines will be a huge immediate DX win. But there are a few things that might be improved.

[coriolinus]

If you set required: true, then wouldn't it always use the default if the user doesn't manually set it? Then we could avoid the ${{ fromJSON(inputs.runs_on || '["self-hosted", "benchmark"]') }} syntax later one.

[typfel]

The this weird syntax to handle manual invocations of the workflow, If we don't care about them we can remove it.

[typfel]

Pushed a change to avoid this syntax, we repeat the runs-on a few times but it's less confusing now I think.

[coriolinus]

I don't love this syntax; it took a minute to figure out. (In part because I'm not familiar with using an array in runs-on.)

docs say that using an array matches only machines for which all tags apply. Do our self-hosted runners have the benchmark tag?

[typfel]

yes one our self host runners have the benchmark tag so that we always run it on the same machine

[coriolinus]

Same comments from the other file also apply here.

[coriolinus]

Same comments from the other file also apply here.

[istankovic]

This name will appear also in the pipeline, right? I think that's confusing, and I wonder if we could rename this to something like "Check benchmarks" in the pipeline.

[typfel]

That doesn't work because this workflow is flow is also used for the real benchmarks.

[typfel]

I mean can rename them of course but it needs to work for benchmark.yml and pipeline.yml

[istankovic]

Is it possible to specify the name at the usage site, i.e. in pipeline.yml?