Fix dropdown yielding options as a collection.#1446
Merged
LukeTowers merged 3 commits intodevelopfrom Feb 7, 2026
Merged
Conversation
WalkthroughAdds a runtime guard that converts Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@modules/backend/widgets/form/partials/_field_dropdown.php`:
- Around line 3-5: Adjust the indentation of the conditional that checks the
type of $fieldOptions so PHPCS expects 0 leading spaces: locate the block that
uses "if ($fieldOptions instanceof Illuminate\Support\Collection)" and the
subsequent "$fieldOptions = $fieldOptions->all();" and remove the extra leading
spaces so both lines begin at column 0 (no indentation).
LukeTowers
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1445
Restores previous behavior.
Added a unittest that triggers the error in the form rendering.
Summary by CodeRabbit
Bug Fixes
Tests