fix: at spr_3c in spr_3c.c#9
Open
orbisai0security wants to merge 1 commit into
Open
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
Resources/sbl6/segalib/spr/spr_3c.c.Vulnerability
V-001Resources/sbl6/segalib/spr/spr_3c.c:1256Description: At spr_3c.c line 1256, memcpy copies vertex normal data from obj->vertNormal into cBuf->vertBright without an explicit bounds check. If the source array (obj->vertNormal) contains more elements than the destination buffer (cBuf->vertBright) can hold, adjacent heap memory is overwritten. This is a classic CWE-120/CWE-787 pattern in a C rendering library that processes external asset data. The copy size appears to be derived from the object structure itself, meaning a crafted asset with an inflated vertex count directly controls the overflow magnitude.
Changes
Resources/sbl6/segalib/spr/spr_3c.cVerification
Automated security fix by OrbisAI Security