Enhance SeqSearch with date range, signals and pagination#3
Open
matt-richardson wants to merge 1 commit intowillibrandon:mainfrom
Open
Enhance SeqSearch with date range, signals and pagination#3matt-richardson wants to merge 1 commit intowillibrandon:mainfrom
matt-richardson wants to merge 1 commit intowillibrandon:mainfrom
Conversation
Add enhancements to SeqSearch tool: New parameters: - signalId: Filter by saved signal/search - fromDateUtc/toDateUtc: Date range filtering (more efficient than @timestamp in filter) - afterId: Pagination support for fetching more than 1000 events - timeoutSeconds: Configurable timeout (1-300 seconds) Improvements: - Filter normalization: Accepts "*" as alias for "all events" (empty string) - Catches SeqApiException for filter syntax errors and provides guidance - Date validation - Signal validation Includes tests: - Date range filtering - Timeout handling - Invalid input validation (dates, signals, filter syntax) - Pagination support - Filter normalization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add enhancements to SeqSearch tool:
New parameters:
Improvements:
Includes tests: