Skip to content

[WFLY-21656] Fixes ha-singleton-deployment quickstart#1146

Open
emmartins wants to merge 1 commit intowildfly:mainfrom
emmartins:WFLY-21656
Open

[WFLY-21656] Fixes ha-singleton-deployment quickstart#1146
emmartins wants to merge 1 commit intowildfly:mainfrom
emmartins:WFLY-21656

Conversation

@emmartins
Copy link
Copy Markdown
Contributor

@emmartins emmartins requested review from kstekovi and rhusar March 23, 2026 18:58
In this example, the service is a timer that is initialized by a `@Startup @Singleton` Jakarta Enterprise Beans bean.
The example is built and packaged as a single web archive.

ifdef::ProductRelease[]
Copy link
Copy Markdown
Contributor Author

@emmartins emmartins Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this is an extra, hiding content that depends on product docs, when not a product release

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is fine. 👍🏼

@emmartins
Copy link
Copy Markdown
Contributor Author

@rhusar @kstekovi any chance I get a review today, or max this week? I would like to have this on WFLY 40 Beta

@rhusar
Copy link
Copy Markdown
Member

rhusar commented Mar 30, 2026

@emmartins Slipped through huge review PR queue, I ll review today. Thanks for reminder.

@rhusar
Copy link
Copy Markdown
Member

rhusar commented Mar 30, 2026

Looking when the bug was introduced and it was for https://redhat.atlassian.net/browse/WFLY-18471 when we did the web app welcome page effort.

Commit was a64b031

Copy link
Copy Markdown
Member

@rhusar rhusar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, thanks @emmartins

With war packaging change above, the src/main/resources/ contents go into WEB-INF/classes/, so the file ended up at where the server doesn't look for it. Thus no demonstration of singleton.

Copy link
Copy Markdown
Contributor

@kstekovi kstekovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The file move to src/main/webapp/META-INF/ is correct for WAR packaging, and the README updates match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants