[WIP; do not merge] Make project installable and testable #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 1, 2017 16:09
You can't just do `composer update` here - that'll try and bring Symfony all the way up to 2.8, which this package isn't ready for! Given that, I ran `composer update --prefer-lowest`. The intention is to update the lock file further in future with newer versions, but this works for now. I did temporarily lock doctrine/common on its original version to avoid that being downgraded for no reason. I added the following to composer.json before running the update, but didn't need to leave it in, since this version-lock is already in the lock file: "doctrine/common": "2.3.x-dev#bb0aebb"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to get to a place where
composer installruns and the project's tests run successfully. I'm not sure that the composer approach I've taken (768d12f) is the right one, but it's one option. Some tests have been fixed in 1b53192, but there are still many more which error (runphp tests.phpto see).Once this PR has been finished, the plan is to build on it to make the bundle fully compatible with Symfony 2.8 (no deprecated calls).