Fix/idempotent cask installation #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add install_cask_if_missing() helper function to check if apps are already installed - Update all cask installations to skip if already installed via Homebrew or in /Applications - Make script fully idempotent - safe to run multiple times - Add setup-mac4dev-skip-installed.sh variant that skips Homebrew, core tools, and IDEs
- Remove the skip-installed variant script as it's no longer needed - Main script now handles idempotent installation checks
There was a problem hiding this comment.
Pull request overview
This PR enhances the macOS setup script to be fully idempotent by adding a helper function that checks for existing installations before attempting to install Homebrew casks. The changes ensure the script can be safely run multiple times without reinstalling already-present applications.
Changes:
- Added
install_cask_if_missing()helper function to check Homebrew and /Applications before installing - Replaced all direct
brew install --caskcommands with calls to the new helper function - Fixed duplicate
disabledfield in Starship time configuration - Removed redundant iTerm2 installation check code (now handled by helper function)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
telekosmos
approved these changes
Jan 21, 2026
Collaborator
telekosmos
left a comment
telekosmos
left a comment
There was a problem hiding this comment.
Not as a common rule, given this one was entirely done by Cursor, I rely on the patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Make cask installation idempotent
Description
This PR improves the setup script to be fully idempotent and removes redundant code.
install_cask_if_missing()helper function to check if applications are already installed via Homebrew or in/Applicationssetup-mac4dev-skip-installed.shvariant script as it's no longer neededType of Change
Checklist