Lots of things: #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Major] - split out Sonnenbatterie API v2 into own class to - make is more easily testable - make it usable on its own - moved APIv2 specific functions to new class - added sb2 object to V1 class so that all V2 functionality can be accessed from V1 as well - split out timeofuse module into own class to make it usable from both API clients - demoted some class methods from timeofuse to functions since they were effectively creating a new class object - fixed some ToU problems where the input was expected to be JSON but was delivered as an object instead [Minor] - corrected all problems related to PEP coding standards - renamed some variables and functions to make the linter happy - added more content to README.md - added `setup.cfg` and `Makefile` to ease builds on non-Windows systems - made sure all tests work again ... and lots more ;) Signed-off-by: stefan <stefan@whocares.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Major]
[Minor]
setup.cfgandMakefileto ease builds on non-Windows systems... and lots more ;)