Skip to content

Conversation

@TtTRz
Copy link
Member

@TtTRz TtTRz commented Dec 30, 2025

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug in the flexbox layout algorithm where flex container sizes were not including gap sizes in their calculations. The fix ensures that when computing the final size of a flex container, both main-axis and cross-axis gaps between flex items are properly accounted for.

Key changes:

  • Added total_gap field to FlexLine struct to cache the calculated gap for each line
  • Updated container size calculations to include gap sizes for both main and cross axes
  • Refactored code to avoid duplicate gap calculations

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
float-pigment-layout/src/algo/flex_box.rs Adds total_gap field to FlexLine struct, calculates and caches gap values, and includes gaps in all container size computations (main axis, cross axis, and free space calculations)
float-pigment-forest/tests/custom/css_flexbox/gap.rs Adds test case validating that flex items correctly shrink when gaps are present and container has a fixed size

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@TtTRz TtTRz merged commit 78729d1 into master Dec 30, 2025
7 checks passed
@TtTRz TtTRz deleted the fix-flex-gap-size branch December 30, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants