Skip to content

fix: replace notification dismiss div with semantic button (#7737) #7747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kritank07 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: replace notification dismiss div with semantic button (#7737) #7747

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfddc01
fix: replace div with semantic button for notification dismissal (#7737)
Kritank07 Jan 16, 2026
1a6ecbb
css corrected for the semantic button
Kritank07 Jan 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/components/NotificationBar/MessageBar.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,18 @@ export default function MessageBar(props) {
>
<Content />
{localStorageIsEnabled ? (
<div
role="button"
<button
type="button"
className="px-20 self-stretch inline-flex items-center cursor-pointer"
style={{ background: 'none', border: 'none'}}
onClick={close}
>
<CloseIcon
aria-label="Dismiss"
className="fill-current text-gray-300 dark:text-white transform duration-200 hover:text-gray-700"
width={25}
/>
</div>
</button>
) : null}
</animated.div>
))}
Expand Down
Loading