feat: use new URL instead of url.parse#5637
Merged
alexander-akait merged 3 commits intonextfrom Feb 1, 2026
Merged
Conversation
Member
alexander-akait
left a comment
There was a problem hiding this comment.
I am fine with this change, feel free to merge when CI will be green, also we have url.parse in our webpack-dev-middleware, make sense to improve this there too for the next major release
f5d7016 to
7e9fc7c
Compare
Member
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #5637 +/- ##
==========================================
+ Coverage 83.56% 83.68% +0.11%
==========================================
Files 11 11
Lines 1947 1955 +8
Branches 723 724 +1
==========================================
+ Hits 1627 1636 +9
+ Misses 287 286 -1
Partials 33 33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjohansebas
commented
Jan 30, 2026
| // If the header does not have a scheme, prepend // so URL can parse it | ||
| const parseUrl = new URL( | ||
| /^(.+:)?\/\//.test(header) ? header : `//${header}`, | ||
| "http://localhost/", |
Member
Author
There was a problem hiding this comment.
This is only for a fallback.
alexander-akait
approved these changes
Feb 1, 2026
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
An important change, IPv6 hostnames now return with square brackets (
[]) (for new URL()), so they need to be formatted foripaddrto correctly validate whether it’s an IPv6 URL. Additionally, the hostname also needs to be formatted in the IPv6 case, because right now, when an IPv6 hostname is passed inhost, users are not including the square brackets. We could change this behavior, what do you think?Also, it seems this will make retrieving the hostname faster.
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?