-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: remove deprecated CLI flags for HTTP/2, HTTPS, and web socket server options #5634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bjohansebas
wants to merge
3
commits into
next
Choose a base branch
from
remove-cli-flags
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+21
−564
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
30054fd
feat: remove deprecated CLI flags for HTTP/2, HTTPS, and web socket s…
bjohansebas 012d844
Merge branch 'next' of github.com:webpack/webpack-dev-server into rem…
bjohansebas 230e15a
chore: update migration guide to reflect removal of deprecated CLI op…
bjohansebas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will just
serverwork? Maybeserver-type? Just to ensure we don't make a typo here 😄There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, do you provide here not CLI options, let's write CLI options here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just write
webpack help serve --verboseand you will see all CLI optionsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I was looking for a way to reproduce and see them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexander-akait I’m not fully understanding this. At what point is the
cli-flags.jsfile executed withinwebpack-cli?I’m asking because many of these options were removed in
webpack-dev-serverv5 — for example in this commit: 1e86e37And this is the commit that updated the README accordingly 5c4006a
So it feels like those options no longer exist starting from
webpack-dev-serverv5, and this file was simply never updated — or maybe I’m missing something?In any case, even when running from
main, those options still don’t show up in the CLI. From what I understand, the file that actually defines the CLI options isoptions.json, which would makecli-flags.jsunnecessary.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, webpack-cli reads this file and getting all CLI flag from this file. Looks like we forgot to remove them. To avoid such things let's add a test case in CLI with
--helpand--verboseso we will have all CLI arguments in our tests