Draft
Conversation
snitin315
requested review from
alexander-akait,
anshumanv,
hiroppy and
knagaitsev
as code owners
| } | ||
| }, | ||
| }, | ||
| }; |
Member
There was a problem hiding this comment.
We should refactor out tests:
- proxyOptionsObject
- proxyOptionsArray
- proxyOptionsObjectWithMiltipleContext
- ...
- proxyOptionOfArrayWithoutTarget
- proxyWithPath
- ...
- proxyWithByPass
9 ...
Now we have mixed tests it is bad for refactor and bad for testing, the latest regression will be due this, so let's refactor our tests
|
|
||
| exports[`proxy option should handles external websocket upgrade with webSocketServerType: ws Should receive response: response status 1`] = `426`; | ||
|
|
||
| exports[`proxy option should handles external websocket upgrade with webSocketServerType: ws Should receive response: response text 1`] = `"Upgrade Required"`; |
snitin315
force-pushed
the
test-e2e-proxy
branch
from
de9e416 to
f777df5
Compare
Member
|
@snitin315 let's finish tests, thanks for help |
snitin315
force-pushed
the
test-e2e-proxy
branch
from
f777df5 to
f2d6da3
Compare
Member
Author
|
All other tests are moved to E2E, let's finish this one too. |
|
@alexander-akait Would like to know what is pending in this PR. I'd like to close it to complete :) |
Member
Author
|
I think need to fix CI |
|
Can you re trigger |
Member
Author
|
I see snapshots needs to be updated. I will push a commit here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
Add e2e tests for
proxyoption.Breaking Changes
None
Additional Info
No