[WIP]: feat: add forwardError option to enable error forwarding to next middleware#2259
Draft
bjohansebas wants to merge 2 commits intonextfrom
Draft
[WIP]: feat: add forwardError option to enable error forwarding to next middleware#2259bjohansebas wants to merge 2 commits intonextfrom
forwardError option to enable error forwarding to next middleware#2259bjohansebas wants to merge 2 commits intonextfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #2259 +/- ##
==========================================
- Coverage 95.67% 95.56% -0.12%
==========================================
Files 13 13
Lines 901 901
Branches 263 263
==========================================
- Hits 862 861 -1
- Misses 39 40 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
alexander-akait
left a comment
There was a problem hiding this comment.
Yeah, not ever frameworks supports it, so we should add this option to docs and write which frameworks support it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While it works fine in Express, I’m not sure how it will behave in other frameworks, so testing is in progress.
What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?