Skip to content

Conversation

@snitin315
Copy link
Member

What kind of change does this PR introduce?

Did you add tests for your changes?

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any blockers that makes this un-mergeable now?

@snitin315
Copy link
Member Author

there's one test case which is failing, I'm looking into it.

@evenstensberg
Copy link
Member

ok

@snitin315 snitin315 marked this pull request as ready for review December 17, 2024 23:13
@snitin315 snitin315 requested a review from a team as a code owner December 17, 2024 23:13
@snitin315 snitin315 merged commit 2163b6a into next Dec 17, 2024
53 checks passed
@snitin315 snitin315 deleted the snitin315-patch-2 branch December 17, 2024 23:32
alexander-akait pushed a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants