Skip to content

Missing trim() for options.name when options is an object #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 2 commits into from
Dec 20, 2025
Merged

Missing trim() for options.name when options is an object #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11d1987
fix: missing trim() for options.name when options is an object
jianyi-gronk Dec 20, 2025
ae415ff
fix: fix lint
jianyi-gronk Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/Hook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,14 @@ class Hook {
_tap(type, options, fn) {
if (typeof options === "string") {
options = {
name: options.trim()
name: options
};
} else if (typeof options !== "object" || options === null) {
throw new Error("Invalid tap options");
}
if (typeof options.name === "string") {
options.name = options.name.trim();
}
if (typeof options.name !== "string" || options.name === "") {
throw new Error("Missing name for tap");
}
Expand Down
6 changes: 6 additions & 0 deletions lib/__tests__/Hook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,5 +100,11 @@ describe("Hook", () => {
expect(() => hook.tap(" ", () => {})).toThrow(
new Error("Missing name for tap")
);
expect(() => hook.tap({ name: "" }, () => {})).toThrow(
new Error("Missing name for tap")
);
expect(() => hook.tap({ name: " " }, () => {})).toThrow(
new Error("Missing name for tap")
);
});
});