Proposed solution to the FCIB Problem#8
Open
codepoet80 wants to merge 13 commits intowebos-internals:masterfrom
Open
Proposed solution to the FCIB Problem#8codepoet80 wants to merge 13 commits intowebos-internals:masterfrom
codepoet80 wants to merge 13 commits intowebos-internals:masterfrom
Conversation
Preware V1.9.16
Member
|
@rwhitby The changes in general look good. I'm not a big fan of the binary being distributed like this, but seeing there is no build infrastructure in place like previously, it's the "necessary evil" I guess. If anyone is really concerned, they probably have the knowledge to build it from scratch themselves anyway. |
Member
|
@codepoet80: You might want to squish your commits together and just a bigger changelog in a single commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generally, checking in binaries is bad -- I get it (see FCIB definition). But we're 12 years past when the ipkgmanager was last modified, and probably almost that long since its
makefile worked for anyone. There's really only two versions of that binary -- one that works on all ARM (including Pixi's v6), and one that works on i686 for the emulator. The PR proposes to just include them both in the source as FCIBs, and in the new build script, swap in the correct one (as defined in a build argument).That plus the aforementioned requirement of supplying signing keys using a previous known-good build, gets us to "stand alone build" on modern dev environments without build infrastructure. The ipkgmanager source could become its own repo for posterity.
Open to other ideas!