Skip to content

Clean Bitonic Sort sample #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greggman merged 1 commit into from
Oct 17, 2025
Merged

Clean Bitonic Sort sample #543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions sample/bitonicSort/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { GUI } from 'dat.gui';
import Stats from 'stats.js';
import { createBindGroupCluster, SampleInitFactoryWebGPU } from './utils';
import BitonicDisplayRenderer from './bitonicDisplay';
import { NaiveBitonicCompute } from './bitonicCompute';
Expand Down Expand Up @@ -632,8 +631,8 @@ SampleInitFactoryWebGPU(
'Next Swap Span'
);

// Timestamp information for Chrome 121+ or other compatible browsers
const timestampFolder = gui.addFolder('Timestamp Info (Chrome 121+)');
// Timestamp information
const timestampFolder = gui.addFolder('Timestamp Info');
const stepTimeController = timestampFolder.add(settings, 'Step Time');
const sortTimeController = timestampFolder.add(settings, 'Sort Time');
const averageSortTimeController = timestampFolder.add(
Expand Down Expand Up @@ -894,10 +893,7 @@ SampleInitFactoryWebGPU(
}
).then((init) => {
const canvas = document.querySelector('canvas') as HTMLCanvasElement;
const stats = new Stats();
const gui = new GUI();

document.body.appendChild(stats.dom);

init({ canvas, stats, gui });
init({ canvas, gui });
});
4 changes: 1 addition & 3 deletions sample/bitonicSort/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ export type ShaderKeyInterface<T extends string[]> = {
export type SampleInitParams = {
canvas: HTMLCanvasElement;
gui?: GUI;
stats?: Stats;
};

interface DeviceInitParms {
Expand All @@ -115,7 +114,7 @@ export type SampleInit = (params: SampleInitParams) => void;
export const SampleInitFactoryWebGPU = async (
callback: SampleInitCallback3D
): Promise<SampleInit> => {
const init = async ({ canvas, gui, stats }) => {
const init = async ({ canvas, gui }) => {
const adapter = await navigator.gpu?.requestAdapter({
featureLevel: 'compatibility',
});
Expand Down Expand Up @@ -150,7 +149,6 @@ export const SampleInitFactoryWebGPU = async (
device,
context,
presentationFormat,
stats,
timestampQueryAvailable,
});
};
Expand Down