Fix: Use configured replacements when dumping table rows in CSV#116
Merged
MalteWunsch merged 3 commits intomasterfrom Sep 5, 2025
Merged
Fix: Use configured replacements when dumping table rows in CSV#116MalteWunsch merged 3 commits intomasterfrom
MalteWunsch merged 3 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the CSV output format driver where configured column replacements were not being applied when dumping table rows to CSV files.
- Adds test coverage for the
CsvOutputFormatDriver->dumpTableRow()method - Implements processing of configured column replacements before writing CSV data
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/Webfactory/Slimdump/Database/CsvOutputFormatDriverTest.php | Adds comprehensive test cases to verify CSV dumping behavior with and without column replacements |
| src/Webfactory/Slimdump/Database/CsvOutputFormatDriver.php | Implements column value processing using configured replacements before writing to CSV |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.