Add class-level #[TranslatedProperty] configuration option#89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
#[Polyglot\TranslatedProperty('propertyName')]PHP attribute that can be placed at the class level to declare the translatable properties.This is a useful alternative to placing
#[Polyglot\Translatable]directly on the property in the case of Doctrine ORM mapped superclasses: Base classes (potentially provided by other libraries) can be extended, and it is left to the extending code to add Polyglot support, without touching the superclass and without re-defining properties (which is not possible with Doctrine ORM).See the
EntityInheritance_MappedSuperclassfixture class added here for an example. Note, however, that this class needs to use a union type includingTranslatableInterface(or no property type at all) to allow subclasses to make fields translatable.