fix(store): attach SDK listeners on stationLoginSuccess#690
Open
vamshigovardhana wants to merge 2 commits into
Open
fix(store): attach SDK listeners on stationLoginSuccess#690vamshigovardhana wants to merge 2 commits into
vamshigovardhana wants to merge 2 commits into
Conversation
addEventListeners() previously ran only in the AGENT_DN_REGISTERED and AGENT_RELOGIN_SUCCESS handlers. When Mobius registration is skipped (Epic Hyperspace non-calling windows, Extension/AgentDN logins) and silent relogin does not run, neither event fires, so agent:stateChange (and related) listeners were never attached and UserState froze. Also invoke addEventListeners() from handleLogin, guarded by the existing listenersAdded flag so listeners attach exactly once regardless of which event fires first. Co-authored-by: Cursor <cursoragent@cursor.com>
vamshigovardhana
changed the title
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Contributor
|
AFAIK, in this scenario we would received AGENT_RELOGIN event and that should add the event listeners. Can you please share a testing video for this fix |
Shreyas281299
requested changes
May 29, 2026
Contributor
Shreyas281299
left a comment
Shreyas281299
left a comment
There was a problem hiding this comment.
Please add test cases and share a testing video for the fix
| // @ts-expect-error To be fixed in SDK - https://jira-eng-sjc12.cisco.com/jira/browse/CAI-6762 | ||
| this.setTeamId(payload.teamId); | ||
| }); | ||
| // CAI-7899: Ensure CC SDK listeners (incl. agent:stateChange) are attached even when |
Contributor
There was a problem hiding this comment.
We dont need to put the CAI ID in code unless its a TODO
Shreyas281299
added
validated
Shreyas281299
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPLETES https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7899
This pull request addresses
UserState (and other CC widgets that depend on
agent:stateChange) freeze in non-WebRTC tabs — e.g. Epic Hyperspace secondary windows that intentionally skip Mobius registration, or any Extension/AgentDN login where Mobius is not registered.Root cause:
addEventListeners()instoreEventsWrapper.setupIncomingTaskHandlerwas only invoked from theAGENT_DN_REGISTEREDandAGENT_RELOGIN_SUCCESShandlers. When Mobius registration is skipped and silent relogin does not run, neither event fires, so theagent:stateChange(and related) listeners are never attached and the store never receives state updates from the SDK.by making the following changes
addEventListeners()from theAGENT_STATION_LOGIN_SUCCESShandler (handleLogin) as well, guarded by the samelistenersAddedflag so listeners are attached exactly once regardless of which event fires first.Builds on the sample-app changes from #683 which add a "Disable WebRTC Registration" toggle for repro convenience.
Change Type
The following scenarios were tested
agent:stateChangelistener is attached onstationLoginSuccess; UserState updates propagate (no freeze).agent:dnRegistered).agent:reloginSuccess) → listener attached exactly once.The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging