Skip to content

fix(meeting join): fail better when we can't find locus join meeting url#4991

Open
lismith2-cisco wants to merge 1 commit into
webex:nextfrom
lismith2-cisco:SPARK-795088-join-existing-1-to-1
Open

fix(meeting join): fail better when we can't find locus join meeting url#4991
lismith2-cisco wants to merge 1 commit into
webex:nextfrom
lismith2-cisco:SPARK-795088-join-existing-1-to-1

Conversation

@lismith2-cisco
Copy link
Copy Markdown
Contributor

COMPLETES # jira-eng-gpk2.cisco.com/jira/browse/SPARK-813470

This pull request addresses

There was a particular scenario where we were not getting enough information to make a locus join meeting url
We ended up using the url "?alternateRedirect=true" which made a POST to the current URL instead of Locus, and the failure reason was unclear.

by making the following changes

Throw an error if the locus join meeting url is empty. The actual bug is fixed in web client.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@lismith2-cisco lismith2-cisco requested review from a team as code owners May 15, 2026 09:54
@aws-amplify-us-east-2
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-4991.d3m3l2kee0btzx.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant