fix(meeting join): fail better when we can't find locus join meeting url#4991
Open
lismith2-cisco wants to merge 1 commit into
Open
fix(meeting join): fail better when we can't find locus join meeting url#4991lismith2-cisco wants to merge 1 commit into
lismith2-cisco wants to merge 1 commit into
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPLETES # jira-eng-gpk2.cisco.com/jira/browse/SPARK-813470
This pull request addresses
There was a particular scenario where we were not getting enough information to make a locus join meeting url
We ended up using the url "?alternateRedirect=true" which made a POST to the current URL instead of Locus, and the failure reason was unclear.
by making the following changes
Throw an error if the locus join meeting url is empty. The actual bug is fixed in web client.
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.