Make webcompat-bug-report semantic.
#190965
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The headings are, now, semantically so (for the sake of screen readers), rather than being poor CSS3 imitations (despite being colon-delimited, which is redundant). 2. Minor punctuation that was previously erroneously absent has been added, like a comma after “Desktop site”. 3. The `name` key of the YAML preamble is consistently title case. 4. The hyphen-minus after “domain name” is, now, an en dash, which is grammatically correct. 5. Placeholders are commented, so that naïve issue authors do not need to worry about whether they need to retain them, because they can't render regardless. 6. The headings are consistently titles, and therefore title case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
The headings are, now, semantically so (for the sake of screen readers), rather than being poor CSS3 imitations (despite being colon-delimited, which is redundant).
Minor punctuation that was previously erroneously absent has been added, like a comma after “Desktop site”.
The
namekey of the YAML preamble is consistently title case.The hyphen-minus after “domain name” is, now, an en dash, which is grammatically correct.
Placeholders are commented, so that naïve issue authors do not need to worry about whether they need to retain them, because they can't render regardless.
The headings are consistently titles, and therefore title case.
Removing the
/nat the bottom of the YAML preamble enables syntax highlighting in GH's UI.With this, it should pass WCAG.
Unmodified
I've left no
/ns between eachli, due togithub/markup/issues/1857.