Add support for Bukkit/Paper 26.1.2#4259
Conversation
✨ feat(spigot/plugin.yml): Update api-version to '26.1.2' for Minecraft 1.21.2 support ➕ build(settings.gradle): Add bukkit-helper-261-2 module for Minecraft 1.21.2 ➕ build(spigot/build.gradle): Add bukkit-helper-261-2 as dependency and include in shadow jar ✨ feat(spigot/Helper.java): Add support for Bukkit/Spigot 26.1.2 version detection and helper loading
⬆️ build(build.gradle): update ASM dependencies to version 9.8 for newer Java class file support
…adle toolchain management
|
The Java portion of this is a line-for-line copy of TwentyOneZ@eff762b . Did you copy it from there? Have you tested this yourself? It was reported on Discord that TwentyOneZ's changes cause trees / plants to render in grayscale. There's a different fork out there that also adds 26.1.2 support and doesn't have the gray issue. |
No, I didn’t copy it from TwentyOneZ’s fork. Yes, I tested it myself before opening the PR, and I’m not reproducing the grayscale foliage issue reported on Discord. |
|
None of that seems right ... getting an exact 100% copy wouldn't happen even if it is straightforward. But being antagonistic won't help. So I'll just point out what I think the leaf color issue is. Your PR updates two functions getFoliageColor / getGrassColor. I don't think they match the last known version from 1.21.11 , which had different method calls. Those different method calls could cause the colors to be wrong in some cases. (maybe they are correct in others). A more accurate version would mirror the method calls in 1.21.11 like this fork. |
2 participants
Add support for Bukkit/Paper 26.1.2
This PR adds compatibility support for Bukkit/Paper
26.1.2by introducing a dedicated helper module and updating the build environment for newer Java class file support.Included changes
bukkit-helper-261-29.5to9.8Unsupported class file major version 69duringshadowJarTesting
Successfully tested on:
26.1.221Build command used: