[Connection-Allowlist] Service Worker WindowClient.navigate()#60335
Draft
chromium-wpt-export-bot wants to merge 1 commit into
Draft
[Connection-Allowlist] Service Worker WindowClient.navigate()#60335chromium-wpt-export-bot wants to merge 1 commit into
chromium-wpt-export-bot wants to merge 1 commit into
Conversation
This CL enforces the Service Worker's Connection-Allowlist policies on navigations triggered via WindowClient.navigate() to see if the URL is allowed. Once the navigation request starts, it considers the document being navigated as the initiator in the current spec and implementation. We keep that invariant and check for the document's CA for URL allowed and redirects too. Test: ConnectionAllowlistTest. ServiceWorkerWindowClientNavigateEnforcesServiceWorkerAndDocumentAllowlists ServiceWorkerWindowClientNavigateRedirectObeysDocumentAllowlist ServiceWorkerWindowClientNavigateObeysDocumentAllowlist WPT: service-worker-navigation.sub.https.window.js Bug: 515272371 Change-Id: I56dc780eee9d92e8f0bdd49bfaf83b9e1d2b71d2
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7871179
branch
from
9fc017b to
a01896c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL enforces the Service Worker's Connection-Allowlist policies
on navigations triggered via WindowClient.navigate() to see if the URL
is allowed.
Once the navigation request starts, it considers the document being
navigated as the initiator in the current spec and implementation.
We keep that invariant and check for the document's CA for URL allowed
and redirects too.
Test:
ConnectionAllowlistTest.
ServiceWorkerWindowClientNavigateEnforcesServiceWorkerAndDocumentAllowlists
ServiceWorkerWindowClientNavigateRedirectObeysDocumentAllowlist
ServiceWorkerWindowClientNavigateObeysDocumentAllowlist
WPT: service-worker-navigation.sub.https.window.js
Bug: 515272371
Change-Id: I56dc780eee9d92e8f0bdd49bfaf83b9e1d2b71d2
Reviewed-on: https://chromium-review.googlesource.com/7871179
WPT-Export-Revision: 4cbb22e5adab8b5b0c3e413f8cf95f2c224f1322