[Gecko Bug 1997338] Clean up attr() cycle leftover from Bug 2009001.#60205
Open
moz-wptsync-bot wants to merge 1 commit into
Open
[Gecko Bug 1997338] Clean up attr() cycle leftover from Bug 2009001.#60205moz-wptsync-bot wants to merge 1 commit into
moz-wptsync-bot wants to merge 1 commit into
Conversation
Specifically: 1. Fix a failing test in attr-cycle.html. Attr-values should only resolve references when prefaced by type() syntax. Else the attr-value is taken as is. 2. Cycle detection currently can't distinguish --data-foo (custom property) from data-foo (attribute), which can flag a false cycle in rare cases. Added a test to attr-cycle.html. 3. CSS-wide keywords aren't meaningful to attr() itself but can pass through directly or via the fallback. Added a test covering this. Differential Revision: https://phabricator.services.mozilla.com/D302511 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1997338 gecko-commit: 93f005409f29cc3f347a99ce9fa0bd53c7ffe5de gecko-commit-git: d3f83bb38dc446c38a9ad37af0bb6c9f511bdfd3 gecko-reviewers: emilio, firefox-style-system-reviewers
wpt-pr-bot
approved these changes
May 27, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically:
Fix a failing test in attr-cycle.html. Attr-values should only
resolve references when prefaced by type() syntax. Else the
attr-value is taken as is.
Cycle detection currently can't distinguish --data-foo (custom
property) from data-foo (attribute), which can flag a false cycle
in rare cases. Added a test to attr-cycle.html.
CSS-wide keywords aren't meaningful to attr() itself but can pass
through directly or via the fallback. Added a test covering this.
Differential Revision: https://phabricator.services.mozilla.com/D302511
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1997338
gecko-commit: 93f005409f29cc3f347a99ce9fa0bd53c7ffe5de
gecko-commit-git: d3f83bb38dc446c38a9ad37af0bb6c9f511bdfd3
gecko-reviewers: emilio, firefox-style-system-reviewers