font: Properly handle when shaping produces no glyphs#60200
Open
servo-wpt-sync wants to merge 1 commit into
Open
font: Properly handle when shaping produces no glyphs#60200servo-wpt-sync wants to merge 1 commit into
servo-wpt-sync wants to merge 1 commit into
Conversation
When shaping produces no glyphs, which can happen when a zero-width space is shaped for a font that has no space or zero-width space glyph, just return an empty `ShapedText` instead of trying to process any glyphs. This prevents logic issues due to the rest of the code assuming there are glyphs. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
wpt-pr-bot
approved these changes
May 27, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
added
stale-servo-export
Collaborator
Author
|
⛔ The downstream PR has merged (servo/servo#45176), but these changes could not be merged properly. Please address any CI issues and try to merge manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When shaping produces no glyphs, which can happen when a zero-width
space is shaped for a font that has no space or zero-width space glyph,
just return an empty
ShapedTextinstead of trying to process anyglyphs. This prevents logic issues due to the rest of the code assuming
there are glyphs.
Testing: This change adds a new WPT crash test.
Fixes: #45174.
Reviewed in servo/servo#45176