Skip to content

Make SubjectCertificateNotRevokedValidator thread-safe #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrts merged 1 commit into from
Mar 10, 2025
Merged

Make SubjectCertificateNotRevokedValidator thread-safe #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...va/eu/webeid/security/validator/certvalidators/SubjectCertificateNotRevokedValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@
public final class SubjectCertificateNotRevokedValidator {

private static final Logger LOG = LoggerFactory.getLogger(SubjectCertificateNotRevokedValidator.class);
private static final DigestCalculator DIGEST_CALCULATOR = DigestCalculatorImpl.sha1();

private final SubjectCertificateTrustedValidator trustValidator;
private final OcspClient ocspClient;
Expand Down Expand Up @@ -197,7 +196,8 @@ private static void checkNonce(OCSPReq request, BasicOCSPResp response) throws U

private static CertificateID getCertificateId(X509Certificate subjectCertificate, X509Certificate issuerCertificate) throws CertificateEncodingException, IOException, OCSPException {
final BigInteger serial = subjectCertificate.getSerialNumber();
return new CertificateID(DIGEST_CALCULATOR,
final DigestCalculator digestCalculator = DigestCalculatorImpl.sha1();
return new CertificateID(digestCalculator,
new X509CertificateHolder(issuerCertificate.getEncoded()), serial);
}

Expand Down
Loading