Skip to content

feat: add support for blobHash property type#1986

Draft
antas-marcin wants to merge 2 commits intomainfrom
add-support-for-blob-hash-property
Draft

feat: add support for blobHash property type#1986
antas-marcin wants to merge 2 commits intomainfrom
add-support-for-blob-hash-property

Conversation

@antas-marcin
Copy link
Collaborator

@antas-marcin antas-marcin commented Mar 14, 2026

Summary

  • Add DataType.BLOB_HASH ("blobHash") to the DataType enum, mirroring the existing BLOB type
  • Add test coverage for the new property type in test_config_create_with_properties

Test plan

  • test_config_create_with_properties passes with the new BLOB_HASH data type across all vectorizer parameterizations

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@antas-marcin antas-marcin marked this pull request as draft March 14, 2026 11:06
Base automatically changed from add-audio-modality-support-for-m2v-google to main March 18, 2026 12:29
@antas-marcin antas-marcin force-pushed the add-support-for-blob-hash-property branch from 40814fa to 6d58d21 Compare March 23, 2026 14:00
Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.85%. Comparing base (ccf4f61) to head (6d58d21).
⚠️ Report is 61 commits behind head on main.

Files with missing lines Patch % Lines
weaviate/collections/config/executor.py 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1986      +/-   ##
==========================================
+ Coverage   87.84%   87.85%   +0.01%     
==========================================
  Files         280      280              
  Lines       21347    21515     +168     
==========================================
+ Hits        18752    18903     +151     
- Misses       2595     2612      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants