Skip to content

Fix headers for http #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rlmanrique wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix headers for http #1885

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
467f1de
Fix headers for http
rlmanrique Nov 27, 2025
1b2f09e
Add additional protections
rlmanrique Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions weaviate/connect/v4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,13 +154,13 @@ def __init__(
self.__add_weaviate_embedding_service_header(connection_params.http.host)
if additional_headers is not None:
_validate_input(_ValidateArgument([dict], "additional_headers", additional_headers))
self.__additional_headers = additional_headers
for key, value in additional_headers.items():
if value is None:
raise WeaviateInvalidInputError(
f"Value for key '{key}' in headers cannot be None."
)
self._headers[key.lower()] = value
self.__additional_headers[key] = str(value)
self._headers[key.lower()] = str(value)

self._proxies: Dict[str, str] = _get_proxies(proxies, trust_env)

Expand Down Expand Up @@ -591,16 +591,16 @@ def periodic_refresh_token(refresh_time: int, _auth: Optional[_Auth]) -> None:

def __get_latest_headers(self) -> Dict[str, str]:
if "authorization" in self._headers:
return self._headers
return {k: str(v) for k, v in self._headers.items()}

auth_token = self.get_current_bearer_token()
if auth_token == "":
return self._headers
return {k: str(v) for k, v in self._headers.items()}

# bearer token can change over time (OIDC) so we need to get the current one for each request
copied_headers = copy(self._headers)
copied_headers.update({"authorization": self.get_current_bearer_token()})
return copied_headers
copied_headers.update({"authorization": str(auth_token)})
return {k: str(v) for k, v in copied_headers.items()}

def __get_timeout(
self,
Expand Down