Skip to content

v6: Guard against null Quantizer in config update #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bevzzz merged 1 commit into from
Nov 22, 2025
Merged

v6: Guard against null Quantizer in config update #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/it/java/io/weaviate/containers/Weaviate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
import io.weaviate.ConcurrentTest;
import io.weaviate.client6.v1.api.Config;
import io.weaviate.client6.v1.api.WeaviateClient;
import io.weaviate.client6.v1.api.collections.Generative;
import io.weaviate.client6.v1.api.collections.Reranker;
import io.weaviate.client6.v1.internal.ObjectBuilder;
import io.weaviate.client6.v1.internal.VersionSupport.SemanticVersion;

Expand Down Expand Up @@ -154,6 +156,7 @@ public static class Builder {
private Map<String, String> environment = new HashMap<>();

public Builder() {
addModules(Reranker.Kind.DUMMY.jsonValue(), Generative.Kind.DUMMY.jsonValue());
enableAutoSchema(false);
}

Expand Down
22 changes: 21 additions & 1 deletion src/it/java/io/weaviate/integration/CollectionsITest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import io.weaviate.client6.v1.api.WeaviateClient;
import io.weaviate.client6.v1.api.collections.CollectionConfig;
import io.weaviate.client6.v1.api.collections.DataType;
import io.weaviate.client6.v1.api.collections.Generative;
import io.weaviate.client6.v1.api.collections.InvertedIndex;
import io.weaviate.client6.v1.api.collections.Property;
import io.weaviate.client6.v1.api.collections.Quantization;
Expand All @@ -19,6 +20,7 @@
import io.weaviate.client6.v1.api.collections.VectorConfig;
import io.weaviate.client6.v1.api.collections.config.Shard;
import io.weaviate.client6.v1.api.collections.config.ShardStatus;
import io.weaviate.client6.v1.api.collections.generative.DummyGenerative;
import io.weaviate.client6.v1.api.collections.vectorindex.Hnsw;
import io.weaviate.client6.v1.api.collections.vectorizers.SelfProvidedVectorizer;
import io.weaviate.containers.Container;
Expand Down Expand Up @@ -234,7 +236,7 @@ public void testNestedProperties() throws IOException {
}

@Test
public void test_updateQuantization() throws IOException {
public void test_updateQuantization_uncompressed() throws IOException {
// Arrange
var nsThings = ns("Things");

Expand All @@ -255,4 +257,22 @@ public void test_updateQuantization() throws IOException {
.extracting(VectorConfig::quantization)
.returns(Quantization.Kind.BQ, Quantization::_kind);
}

@Test
public void test_updateGenerative() throws IOException {
// Arrange
var nsThings = ns("Things");

var things = client.collections.create(nsThings,
c -> c.vectorConfig(VectorConfig.selfProvided()));

// Act
things.config.update(c -> c.generativeModule(new DummyGenerative()));

// Assert
var config = things.config.get();
Assertions.assertThat(config).get()
.extracting(CollectionConfig::generativeModule).isNotNull()
.returns(Generative.Kind.DUMMY, Generative::_kind);
}
}
2 changes: 1 addition & 1 deletion src/main/java/io/weaviate/client6/v1/api/collections/config/UpdateCollectionRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public record UpdateCollectionRequest(CollectionConfig updated, CollectionConfig
for (var origVector : request.original.vectors().entrySet()) {
var vectorName = origVector.getKey();
var origQuantization = origVector.getValue().quantization();
if (vectors.has(vectorName)) {
if (vectors.has(vectorName) && origQuantization != null) {
vectors
.get(vectorName).getAsJsonObject()
.get("vectorIndexConfig").getAsJsonObject()
Expand Down