Skip to content

Conversation

@taojoe
Copy link

@taojoe taojoe commented Dec 14, 2018

when an sql file starts with "--transaction-off", means turn transaction off.
and print every sql when migrate.

@weavejester
Copy link
Owner

Thank you for the PR, however I'd rather we didn't add more special meaning to the filename. I'd consider implementing this as a specially-formatted comment but I'd need to think about it.

Also commit messages should be written in English and according to the contributing guidelines, and the commits should pass CI.

@taojoe
Copy link
Author

taojoe commented Jan 3, 2019

it's not file name, it's file content starts with.

@weavejester
Copy link
Owner

Sorry, I misunderstood you previously. I think I'd prefer a comment like -- transactions: off, but it should be matched case insensitively and ignore whitespace and previous comments. I think we should also allow off, false, no, true, on and yes as valid values, similar to YAML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants