Fix NPE when pretty/report called outside test#36
Open
ryfow wants to merge 1 commit intoweavejester:masterfrom
Open
Fix NPE when pretty/report called outside test#36ryfow wants to merge 1 commit intoweavejester:masterfrom
pretty/report called outside test#36ryfow wants to merge 1 commit intoweavejester:masterfrom
Conversation
Owner
|
Can you provide an example of what you mean? |
Contributor
Author
|
In a project I maintain, I do some cleanup work in a fixture. If there's a problem, I call report with a specific file/line based on my stack because the file/line of the cleanup job isn't really that interesting. I can't give you my project, but here's an example of the sort of think I'm doing: (ns eftest.fixture-fail
(:require [clojure.test :refer :all]))
(defn failing-fixture [f]
(f)
(clojure.test/report {:type :fail :message "This fixture noticed a problem"
:file "file_name.clj"
:line 10}))
(use-fixtures :each failing-fixture)
(deftest foo
(is (= 1 1)))If I run this with If I run it with |
Owner
|
Should
|
`report` can be run from code fixtures which caused `pretty/testing-vars-str` to throw a NullPointerException because *testing-vars* is nil inside fixtures.
ryfow
force-pushed
the
fixture-reporting
branch
from
a28f8bd to
467fbab
Compare
Contributor
Author
|
I guess you could argue that. In my case, I have a function in my test code that checks status codes and calls I could wrap my I updated the test to set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reportcan be run from code fixtures which causedpretty/testing-vars-strto throw a NullPointerExceptionbecause testing-vars is nil inside fixtures.