-
Notifications
You must be signed in to change notification settings - Fork 0
feature/atomic structure #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shsavage1993
wants to merge
10
commits into
develop
Choose a base branch
from
feature/atomic-structure
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0cb62d5
Added atomic structuring for components and added examples for each: …
shsavage1993 30e8c88
amended storybook configuration
shsavage1993 f64f426
removed redundant svg files
shsavage1993 0dfed26
fixed exports for all components and atoms, molecules and organisms f…
shsavage1993 7876159
removed carousel component and fixed small bugs
shsavage1993 ff14536
removed export of ./molecules as there are no components yet
shsavage1993 e5de657
fixed TS6133 error
shsavage1993 edb5cd8
Fixed scss error
johnfedoruk b43cb60
Fixed import issue with @ alias
johnfedoruk 0b94d29
Fixed additional build errors related to SCSS
johnfedoruk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| export interface ImageDTO { | ||
| // id: string; | ||
| alt: string; | ||
| // filename: string; | ||
| // mimeType: string; | ||
| // filesize: number; | ||
| width: number; | ||
| height: number; | ||
| focalX?: number; | ||
| focalY?: number; | ||
| sizes?: { | ||
| [key: string]: ResizedImage; | ||
| }; | ||
| // createdAt: string; | ||
| // updatedAt: string; | ||
| url: string; | ||
| // thumbnailURL: string; | ||
| } | ||
|
|
||
| export interface ResizedImage { | ||
| width: number; | ||
| height: number; | ||
| mimeType: string; | ||
| filesize: number; | ||
| filename: string; | ||
| url: string; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| export interface LinkDTO { | ||
| variant?: "primary" | "secondary" | "icon" | "underline"; | ||
| href: string; | ||
| label: string; | ||
| newTab: boolean; | ||
| isHidden: boolean; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,30 +1,87 @@ | ||
| // globals.scss | ||
|
|
||
| // Import variables and mixins | ||
| @import 'vars'; | ||
| @import 'mixins'; | ||
| @import 'typography'; | ||
| @import "vars"; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| @import "mixins"; | ||
| @import "typography"; | ||
|
|
||
| // for an intro on how this works, see https://www.youtube.com/watch?v=c13gpBrnGEw&t=839s | ||
| .content-grid, | ||
| .full-width { | ||
| --content-padding: 24px; | ||
| display: grid; | ||
| row-gap: 0; | ||
| grid-template-columns: | ||
| [full-width-start] minmax(var(--content-padding), 1fr) | ||
| [content-start] min( | ||
| calc(100% - (var(--content-padding) * 2)), | ||
| calc($breakpoints-xxl + (var(--content-padding) * 2)) | ||
| ) | ||
| [content-end] | ||
| minmax(var(--content-padding), 1fr) [full-width-end]; | ||
|
|
||
| > :not(.full-width) { | ||
| grid-column: content; | ||
| } | ||
|
|
||
| > .full-width { | ||
| grid-column: full-width; | ||
| } | ||
|
|
||
| @media screen and (max-width: $breakpoints-lg) { | ||
| --content-padding: 16px; | ||
| } | ||
| } | ||
|
|
||
| .disable-scroll { | ||
| overflow: hidden; | ||
| } | ||
|
|
||
| // for screen reader only - hides elements from view | ||
| .sr-only { | ||
| position: absolute; | ||
| width: 1px; | ||
| height: 1px; | ||
| margin: -1px; | ||
| padding: 0; | ||
| overflow: hidden; | ||
| clip: rect(0, 0, 0, 0); | ||
| border: 0; | ||
| } | ||
|
|
||
| // Global reset or normalize styles | ||
| * { | ||
| margin: 0; | ||
| padding: 0; | ||
| box-sizing: border-box; | ||
| } | ||
|
|
||
| // Body styles | ||
| html, | ||
| body { | ||
| background-color: $background-color; | ||
| color: $text-color; | ||
| font-family: 'Roboto', sans-serif; | ||
| font-size: $base-font-size; | ||
| line-height: $base-line-height; | ||
| max-width: 100dvw; | ||
| overflow-x: hidden; | ||
| } | ||
|
|
||
| // remove default styles | ||
| li { | ||
| list-style: none; | ||
| } | ||
|
|
||
| a { | ||
| color: inherit; | ||
| text-decoration: none; | ||
| } | ||
|
|
||
| button { | ||
| background: none; | ||
| color: inherit; | ||
| border: none; | ||
| padding: 0; | ||
| font: inherit; | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| // Utility classes | ||
| .container { | ||
| @include center(80%); | ||
| padding: $spacing-unit; | ||
| select { | ||
| font-family: inherit; | ||
| } | ||
|
|
||
| .clearfix { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added for module aliasing