Add transactional start slot tracking and unit tests for bids service #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace simple LatestSlot assignment with new updateStartSlot() function that properly handles per-provider slot tracking - Implement transaction-based metadata updates using BeginTx/SetMetadata/CommitTx pattern for atomicity and consistency - Set LatestSlots for each relay provider instead of single LatestSlot field - Add proper error handling with context cancellation on transaction failure
- Generate mock implementations for `chaintime`, relay client providers, and comptrollerdb setters using testify/mockery - Add handler_test.go with tests for bid handling, deduplication, and error cases - Add metadata_test.go with tests for metadata get/set and format upgrades - Add parameters_test.go with tests for parameter validation and startSlot handling - Add service_test.go with tests for Service initialization, transaction handling, and start slot logic
- Add optional expectation for ReceivedHandler.BidsReceived() call in TestCatchupProviderSlot_WithHandlers test - Ensures mock handler properly handles invocations during slot catchup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds proper transactional handling for start slot metadata updates in the bids service and comprehensive unit test coverage.
Changes
BeginTx/SetMetadata/CommitTxpattern for atomicity and consistencyMotivation
This work ensures that start slot metadata updates are handled transactionally, maintaining consistency across relay providers, and provides test coverage for core bids service functionality.
Testing
All new tests pass and validate the implementation across multiple scenarios including success cases, error handling, and edge cases.