-
Notifications
You must be signed in to change notification settings - Fork 5
rename package xivo to wazo #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Build failed. ❌ tox-linters FAILURE in 6m 26s |
2be6fc9 to
abac82e
Compare
|
Build succeeded. ✔️ tox-linters SUCCESS in 6m 30s |
|
Build succeeded. ✔️ tox-linters SUCCESS in 6m 39s |
the goal is to still provide the xivo package for a while without having too much code to maintain to keep it working
62dac9f to
2ab68c2
Compare
|
Build succeeded. ✔️ tox-linters SUCCESS in 4m 22s |
use a python alias to deprecate the xivo package instead of a symlink. this allows the deprecation warning to be displayed
|
Build succeeded. ✔️ tox-linters SUCCESS in 6m 22s |
Don't worry, I'm just having fun
Using the depends on comment on dependencies does not work because the script that finds sibling python packges does not work when renaming the top level packages.
xivois installed and the dependency does not installxivoso it got nothing to override. There might be a work around using theobsoletesoption in setup.py but I'm still unsure it the change would be simple enough to warrant a fix to the script or if I should just merge the change to lib-python first with the compatibility module to avoid breaking everything and then merge all other PR with a dependency